Skip to content

Table policy form warning firing incorrectly fix#602

Merged
joncombe merged 1 commit into
masterfrom
jc/table-policy-warning-firing-fix
May 27, 2026
Merged

Table policy form warning firing incorrectly fix#602
joncombe merged 1 commit into
masterfrom
jc/table-policy-warning-firing-fix

Conversation

@joncombe
Copy link
Copy Markdown
Contributor

@joncombe joncombe commented May 27, 2026

Summary of changes

This problem was caused by two related bugs:

  • some synchronous code was firing during some async code execution, despite relying on the result of the async output.
  • a useEffect was missing a required value causing it not to fire certain cases

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/2678
  • Relevant changes are reflected in CHANGES.md.
  • Added or changed code is covered by tests.
  • Required Grand Central APIs are already merged.

@joncombe joncombe requested review from kneth and plaharanne May 27, 2026 05:51
Copy link
Copy Markdown
Member

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joncombe joncombe force-pushed the jc/table-policy-warning-firing-fix branch 2 times, most recently from 5bf85c0 to ec02d26 Compare May 27, 2026 08:07
@joncombe joncombe force-pushed the jc/table-policy-warning-firing-fix branch from ec02d26 to b1d2a48 Compare May 27, 2026 08:14
@joncombe joncombe merged commit 2daadff into master May 27, 2026
2 checks passed
@joncombe joncombe deleted the jc/table-policy-warning-firing-fix branch May 27, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants